start = 2021-02-21 20:50
end = 2021-02-21 21:05
reviewer = Stefan Hanreich stefa.nosp@m.nhan.nosp@m.i@gma.nosp@m.il.c.nosp@m.om

ssize_t keyIncRef(Key *key)

(bullet points are in order of appearance)

[ ] First line explains briefly what the function does
- [ ] change viability to 'reference counter'
[ ] Simple example or snippet how to use the function
- [ ] add example
[x] Longer description of function containing common use cases
[x] Description of functions reads nicely
[ ] @pre
- [ ]
  Precondition
  key is a valid key
[ ] @post
- [ ]
  Postcondition
  reference counter of the key is incremented by one
[ ] @invariant
- [ ]
  Invariant
  key stays a valid key
[x] @param for every parameter
[x] @return / @retval
[ ] @since
- [ ] add
[x] `
[ ]
See also
[ ] addkeyGetRef() [ ] addkeyDecRef()`


[ ] Abbreviations used in function names must be defined in the Glossary
[ ] add inc to glossary
[ ] add ref to glossary


[x] Function names should neither be too long, nor too short
[x] Function name should be clear and unambiguous
Abbreviations used in parameter names must be defined in the Glossary
[x] Parameter names should neither be too long, nor too short
[x] Parameter names should be clear and unambiguous

(only in PRs)


Symbol versioning is correct for breaking changes
ABI/API changes are forward-compatible (breaking backwards-compatibility to add additional symbols is fine)


Function parameters should use enum types instead of boolean types wherever sensible
[x] Wherever possible, function parameters should be const
[x] Wherever possible, return types should be const
[x] Functions should have the least amount of parameters feasible


[x] Functions should do exactly one thing
[x] Function name has the appropriate prefix
[x] Order of signatures in kdb.h.in is the same as Doxygen
[x] No functions with similar purpose exist


[x] Memory Management should be handled by the function wherever possible


Function is easily extensible, e.g., with flags
[ ] Documentation does not impose limits, that would hinder further extensions


[x] Function code is fully covered by tests
[ ] All possible error states are covered by tests
[ ] add test for null pointer


All possible enum values are covered by tests
[x] No inconsistencies between tests and documentation