
\begin{DoxyItemize}
\item start = 2021-\/02-\/22 13\+:10
\item end = 2021-\/02-\/22 13\+:40
\item moderator = Stefan Hanreich \href{mailto:stefanhani@gmail.com}{\tt stefanhani@gmail.\+com}
\item reviewer = Philipp Gackstatter
\end{DoxyItemize}

{\ttfamily ssize\+\_\+t \hyperlink{group__keyname_gabdbcfa51ed8a387e47ead207affa2d2e}{key\+Get\+Name\+Size(const Key $\ast$key)}}

(bullet points are in order of appearance)


\begin{DoxyItemize}
\item \mbox{[} \mbox{]} First line explains briefly what the function does
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} only describes return value
\item \mbox{[} \mbox{]} null-\/termination
\item \mbox{[} \mbox{]} mit return mergen
\end{DoxyItemize}
\item \mbox{[} \mbox{]} Simple example or snippet how to use the function
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add
\end{DoxyItemize}
\item \mbox{[} \mbox{]} Longer description of function containing common use cases
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} better describe common use case
\item \mbox{[} \mbox{]} example for error case
\item \mbox{[} \mbox{]} example for empty string
\end{DoxyItemize}
\item \mbox{[}x\mbox{]} Description of functions reads nicely
\item \mbox{[} \mbox{]} {\ttfamily @pre}
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add \textquotesingle{}Key should be valid\textquotesingle{}
\end{DoxyItemize}
\item \mbox{[} \mbox{]} {\ttfamily @post}
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add \textquotesingle{}key doesn\textquotesingle{}t get modified\textquotesingle{}
\end{DoxyItemize}
\item \mbox{[} \mbox{]} {\ttfamily @invariant}
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add \textquotesingle{}key doesn\textquotesingle{}t get modified\textquotesingle{}
\end{DoxyItemize}
\item \mbox{[} \mbox{]} {\ttfamily @param} for every parameter
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} \textquotesingle{}key object to get the size of the name from\textquotesingle{}
\item \mbox{[} \mbox{]} make consistent
\end{DoxyItemize}
\item \mbox{[} \mbox{]} {\ttfamily @return} / {\ttfamily @retval}
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} without owner?
\end{DoxyItemize}
\item \mbox{[} \mbox{]} {\ttfamily @see}
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add parentheses to key\+Get\+Unescaped\+Name\+Size
\end{DoxyItemize}
\end{DoxyItemize}


\begin{DoxyItemize}
\item Abbreviations used in function names must be defined in the \hyperlink{doc_help_elektra-glossary_md}{Glossary}
\item \mbox{[}x\mbox{]} Function names should neither be too long, nor too short
\item \mbox{[}x\mbox{]} Function name should be clear and unambiguous
\item Abbreviations used in parameter names must be defined in the \hyperlink{doc_help_elektra-glossary_md}{Glossary}
\item \mbox{[}x\mbox{]} Parameter names should neither be too long, nor too short
\item \mbox{[}x\mbox{]} Parameter names should be clear and unambiguous
\end{DoxyItemize}

(only in P\+Rs)


\begin{DoxyItemize}
\item \hyperlink{doc_dev_symbol-versioning_md}{Symbol versioning} is correct for breaking changes
\item A\+B\+I/\+A\+PI changes are forward-\/compatible (breaking backwards-\/compatibility to add additional symbols is fine)
\end{DoxyItemize}


\begin{DoxyItemize}
\item Function parameters should use enum types instead of boolean types wherever sensible
\item \mbox{[}x\mbox{]} Wherever possible, function parameters should be {\ttfamily const}
\item \mbox{[}x\mbox{]} Wherever possible, return types should be {\ttfamily const}
\item \mbox{[}x\mbox{]} Functions should have the least amount of parameters feasible
\end{DoxyItemize}


\begin{DoxyItemize}
\item \mbox{[}x\mbox{]} Functions should do exactly one thing
\item \mbox{[}x\mbox{]} Function name has the appropriate prefix
\item \mbox{[}x\mbox{]} Order of signatures in kdb.\+h.\+in is the same as Doxygen
\item \mbox{[}x\mbox{]} No functions with similar purpose exist
\end{DoxyItemize}


\begin{DoxyItemize}
\item Memory Management should be handled by the function wherever possible
\end{DoxyItemize}


\begin{DoxyItemize}
\item \mbox{[}x\mbox{]} Function is easily extensible, e.\+g., with flags
\item \mbox{[}x\mbox{]} Documentation does not impose limits, that would hinder further extensions
\end{DoxyItemize}


\begin{DoxyItemize}
\item \mbox{[}x\mbox{]} Function code is fully covered by tests
\item \mbox{[} \mbox{]} All possible error states are covered by tests
\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add test case for N\+U\+LL pointer
\end{DoxyItemize}
\item All possible enum values are covered by tests
\item \mbox{[}x\mbox{]} No inconsistencies between tests and documentation
\end{DoxyItemize}

try splitting ifs to two lines, for better coverage reports