$darkmode
Elektra 0.11.0
ksAppend

Signature

ssize_t ksAppend(KeySet *ks, const KeySet *toAppend)

Checklist

Doxygen

(bullet points are in order of appearance)

  • [ ] First line explains briefly what the function does
    • [ ] 'Append all keys from toAppend to the end of KeySet ks'
  • [ ] Simple example or snippet how to use the function
    • [ ] add
  • [x] Longer description of function containing common use cases
  • [x] Description of functions reads nicely
  • [ ] @pre
    • [ ] add
  • [x] @post
  • [ ] @invariant
    • [ ] add
  • [ ] @param for every parameter
    • [ ] move above return
  • [x] @return / @retval
  • [ ] @since
    • [ ] add
  • [x] @ingroup
  • [x] @see

Naming

  • [ ] Abbreviations used in function names must be defined in the Glossary
    • [ ] define ks
  • [x] Function names should neither be too long, nor too short
  • [x] Function name should be clear and unambiguous
  • [ ] Abbreviations used in parameter names must be defined in the Glossary
    • [ ] define ks
  • [x] Parameter names should neither be too long, nor too short
  • [ ] Parameter names should be clear and unambiguous
    • [ ] ks -> keySet

Compatibility

(only in PRs)

  • Symbol versioning is correct for breaking changes
  • ABI/API changes are forward-compatible (breaking backwards-compatibility to add additional symbols is fine)

Parameter & Return Types

  • Function parameters should use enum types instead of boolean types wherever sensible
  • [x] Wherever possible, function parameters should be const
  • [x] Wherever possible, return types should be const
  • [x] Functions should have the least amount of parameters feasible

Structural Clarity

  • [x] Functions should do exactly one thing
  • [x] Function name has the appropriate prefix
  • [ ] Order of signatures in kdb.h.in is the same as Doxygen
    • [ ] fix
  • [x] No functions with similar purpose exist

Memory Management

  • [x] Memory Management should be handled by the function wherever possible

Extensibility

  • [x] Function is easily extensible, e.g., with flags
  • [x] Documentation does not impose limits, that would hinder further extensions

Tests

  • [ ] Function code is fully covered by tests
    • [x] Line 923
  • [ ] All possible error states are covered by tests
    • [x] add test case for ks == NULL
    • [x] add test case for toAppend == NULL
  • All possible enum values are covered by tests
  • [x] No inconsistencies between tests and documentation

Summary

Other Issues discovered (unrelated to function)